Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix reference cycle in gluon.Trainer #18363

Merged
merged 3 commits into from
May 20, 2020
Merged

Conversation

leezu
Copy link
Contributor

@leezu leezu commented May 19, 2020

Fix reference cycle preventing reference-counting based deallocation of NDArrays due to gluon.Trainer.

cc @eric-haibin-lin

@leezu leezu requested a review from szha as a code owner May 19, 2020 02:37
@mxnet-bot
Copy link

Hey @leezu , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [centos-cpu, website, unix-gpu, clang, sanity, miscellaneous, windows-cpu, windows-gpu, centos-gpu, unix-cpu, edge]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@leezu leezu added the pr-awaiting-review PR is waiting for code review label May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants