Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[1.x] Fix memory leaks in Gluon #18359

Merged
merged 1 commit into from
May 27, 2020
Merged

[1.x] Fix memory leaks in Gluon #18359

merged 1 commit into from
May 27, 2020

Conversation

leezu
Copy link
Contributor

@leezu leezu commented May 18, 2020

Backport #18328

Fix leak of ndarray objects in the frontend due to reference cycle.

Backport of 3e676fc
@leezu leezu requested a review from szha as a code owner May 18, 2020 20:33
@mxnet-bot
Copy link

Hey @leezu , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [miscellaneous, website, unix-gpu, clang, centos-cpu, windows-gpu, windows-cpu, edge, centos-gpu, unix-cpu, sanity]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@leezu leezu added the v1.x Targeting v1.x branch label May 18, 2020
@ciyongch
Copy link
Contributor

Hi @leezu , please help to re-trigger the failed CI :)

@leezu
Copy link
Contributor Author

leezu commented May 26, 2020

@mxnet-bot run ci [all]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-cpu, unix-gpu, centos-gpu, edge, windows-cpu, centos-cpu, website, sanity, miscellaneous, clang, windows-gpu]

@ciyongch
Copy link
Contributor

@TaoLv @pengzhao-intel @szha please take a review and help to merge it, the counterpart PR #18358 to v1.7.x was already merged.

@TaoLv TaoLv merged commit b523527 into apache:v1.x May 27, 2020
@leezu leezu deleted the 1xmemleak branch May 27, 2020 03:07
rondogency added a commit to rondogency/incubator-mxnet that referenced this pull request Jul 13, 2020
ChaiBapchya pushed a commit to ChaiBapchya/mxnet that referenced this pull request Aug 15, 2020
Fix leak of ndarray objects in the frontend due to reference cycle.

Backport of 3e676fc
leezu added a commit that referenced this pull request Sep 18, 2020
samskalicky pushed a commit that referenced this pull request Sep 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
v1.x Targeting v1.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants