This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Fix FInferShape for some ops to support partial type inference #18348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Serge Panev <spanev@nvidia.com>
|
Hey @Kh4L , Thanks for submitting the PR
CI supported jobs: [miscellaneous, unix-cpu, windows-cpu, clang, centos-gpu, website, edge, windows-gpu, centos-cpu, unix-gpu, sanity] Note: |
Signed-off-by: Serge Panev <spanev@nvidia.com>
AntiZpvoh
pushed a commit
to AntiZpvoh/incubator-mxnet
that referenced
this pull request
Jul 6, 2020
…e#18348) * Fix FInferShape for some ops to support partial type inference Signed-off-by: Serge Panev <spanev@nvidia.com> * Add missing ndim check in in matrix_op-inl.h Signed-off-by: Serge Panev <spanev@nvidia.com>
Kh4L
added a commit
to Kh4L/incubator-mxnet
that referenced
this pull request
Aug 10, 2020
Signed-off-by: Serge Panev <spanev@nvidia.com>
Kh4L
added a commit
to Kh4L/incubator-mxnet
that referenced
this pull request
Aug 11, 2020
Signed-off-by: Serge Panev <spanev@nvidia.com>
Kh4L
added a commit
to Kh4L/incubator-mxnet
that referenced
this pull request
Aug 12, 2020
Signed-off-by: Serge Panev <spanev@nvidia.com>
ptrendx
pushed a commit
that referenced
this pull request
Aug 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some operators were checking
ndim_is_knownon the input shape after accessing it, resulting in a runtime error.This was preventing us from running a partial shape inference where some not (yet) defined input shape would trigger an exception.
This PR fixes it by adding the
ndim_is_knowncheck (or changing it to the correct position) in theFInferShapefunction of those operators.