This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
CI: Attempt fixing illegal instruction errors #17842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leezu
force-pushed
the
fixciillegalinstruction
branch
from
6282b89
to
f08991e
Compare
Caching the source-compiled variants via our Docker cache can lead to "Illegal instruction" errors when deploying the docker image on an older machines.
leezu
force-pushed
the
fixciillegalinstruction
branch
from
f08991e
to
157ca6b
Compare
|
Could you elaborate what that flag exactly does? |
|
Will this fix the issue #17840? |
apeforest
approved these changes
Mar 16, 2020
|
@marcoabreu the flag disables AVX instruction set. https://github.com/facebook/zstd contains code that can be vectorized. For whatever reason, gcc uses avx instruction set even if it shouldn't (cf #14664) and we need to explicitly disable it as the resulting binary is used on different machines thanks to the docker cache. |
|
@apeforest I'm not sure about the TVM problem. I'm attempting to fix the following problem: |
|
It's not really nice to merge a PR while there are still open questions.... Will this globally disable the AVX instruction set? |
|
@marcoabreu this fixes a bug in #17828 which you approved before. It's urgent as it blocks all CI runs. @apeforest approved this PR, which is why I merged the PR. |
|
Oh I didn't know it blocked. In that case, fine with me. Thanks for elaborating. Sounds good. |
leezu
added a commit
to leezu/mxnet
that referenced
this pull request
Mar 17, 2020
…ache#17842)" This reverts commit bd6b80e.
MoisesHer
pushed a commit
to MoisesHer/incubator-mxnet
that referenced
this pull request
Apr 10, 2020
Caching the source-compiled variants of libzstd1 and libb2 via our Docker cache can lead to "Illegal instruction" errors when deploying the docker image on an older machines.
anirudh2290
pushed a commit
to anirudh2290/mxnet
that referenced
this pull request
May 29, 2020
Caching the source-compiled variants of libzstd1 and libb2 via our Docker cache can lead to "Illegal instruction" errors when deploying the docker image on an older machines.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hypothesis: Caching the source-compiled variants of libzstd1 and libb2 via our Docker cache can lead to "Illegal instruction" errors when deploying the docker image on an older machines. If so, switching to the distribution provided variants will solve the issue.
Follow-up on #17828