This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Add support of plug and play fit_batch and evaluate_batch #16982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roywei
approved these changes
Dec 5, 2019
leezu
reviewed
Dec 6, 2019
leezu
reviewed
Dec 6, 2019
There was a problem hiding this comment.
************* Module mxnet.gluon.contrib.estimator.estimator_model
python/mxnet/gluon/contrib/estimator/estimator_model.py:102:0: C0303: Trailing whitespace (trailing-whitespace)
python/mxnet/gluon/contrib/estimator/estimator_model.py:22:0: W0611: Unused import warnings (unused-import)
************* Module mxnet.gluon.contrib.estimator.estimator
python/mxnet/gluon/contrib/estimator/estimator.py:397:0: C0330: Wrong continued indentation (add 50 spaces).
batch, batch_axis)
^ | (bad-continuation)
leezu
reviewed
Dec 6, 2019
leezu
approved these changes
Dec 10, 2019
|
@ptrendx, let's also consider this one if it's merged to master in time (expected to be merged in 12 hours after fixing the conflict) |
liuzh47
force-pushed
the
estimatormodel
branch
from
dc60e80
to
442118f
Compare
ptrendx
pushed a commit
to ptrendx/mxnet
that referenced
this pull request
Dec 11, 2019
* Add support of plug and play fit_batch and evaluate_batch * Add check for the validity of the estimator model * Rename estimator model as batch processor * Remove unused import * Add documentation of the batch processor class * refine the documentation of the batch processor * Fix merge bugs * fix bugs introduced during merge * fix sanity check failures * fix CI bugs
ptrendx
added a commit
that referenced
this pull request
Dec 11, 2019
* Include eval_net the validation model in the gluon estimator api (#16957) * Include eval_net the validation model in the estimator api * fix small issue * Extend estimator.evaluate() to support event handlers (#16971) * fix unittest failures for the new api interface * Add comments in the code for readability * Remove unused argument val_metrics * merge changes with the master branch * fix some regression errors * fix bugs introduced in the merging phase * Add support of plug and play fit_batch and evaluate_batch (#16982) * Add support of plug and play fit_batch and evaluate_batch * Add check for the validity of the estimator model * Rename estimator model as batch processor * Remove unused import * Add documentation of the batch processor class * refine the documentation of the batch processor * Fix merge bugs * fix bugs introduced during merge * fix sanity check failures * fix CI bugs * Fix Gluon Estimator nightly test (#17042)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to the potential estimator explosion issue introduced in issue #16930, we add support of plug and play
fit_batch()andevaluate_batch()methods for the base estimator class. Concretely,we define a new class
BatchProcessorand use it to wrap thefit_batch()andevaluate_batch()methods. Our contribution can be summarized as belowBatchProcessorto support plug and playfit_batchandevaluate_batchfor existing estimators.fit_batch()andevaluate_batch()methodsFix Issue #16930