This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[CD] dynamic libmxet pipeline fix + small fixes #16966
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for the fix @perdasilva. Where can I find the broken status of CD? |
zachgk
approved these changes
Dec 3, 2019
marcoabreu
approved these changes
Dec 4, 2019
perdasilva
force-pushed
the
cd_dynlib_fix
branch
from
December 5, 2019 08:10
4c2d606
to
4a4d0e3
Compare
@TaoLv sorry for the delay in responding. CD runs on a daily cadance here - if you have access, you can also test any changes to the CD pipeline on jenkins dev by updating the configuration for this job by pointing it to your repository and changing the branch specified to point to your branch. That would give you a dry run of CD. |
@DickJC123, I'm trying to fix CD and I think it's been failing since the fuse op PR. Do you have any idea why it could be failing for the cuda 9.0 builds?
|
perdasilva
force-pushed
the
cd_dynlib_fix
branch
from
December 5, 2019 15:51
4a4d0e3
to
52e0767
Compare
perdasilva
changed the title
[CD] dynamic libmxet pipeline fix
[WIP][CD] dynamic libmxet pipeline fix
Dec 5, 2019
I'll work with @ptrendx to resolve this. |
perdasilva
force-pushed
the
cd_dynlib_fix
branch
from
December 9, 2019 07:33
52e0767
to
9e987a3
Compare
perdasilva
changed the title
[WIP][CD] dynamic libmxet pipeline fix
[CD] dynamic libmxet pipeline fix + small fixes
Dec 9, 2019
@DickJC123 I've created an issue to track this problem: #17020 - thanks again for looking into it |
perdasilva
force-pushed
the
cd_dynlib_fix
branch
from
December 10, 2019 07:27
9e987a3
to
ec02673
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MKL builds for the dynamic libmxet are failing because because of a previous PR's change. It deleted
mx_mkldnn_deps
from the Jenkins file, however, this is needed by an underlying import.I also noticed a couple of inconsistencies:
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.