This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[MKL-DNN] Enable and Optimization for s8 eltwise_add #16931
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rongzha1
reviewed
Nov 29, 2019
xinyu-intel
force-pushed
the
s8_sum_opt_master
branch
from
December 2, 2019 02:46
bbf9d67
to
e7ca023
Compare
rongzha1
approved these changes
Dec 2, 2019
TaoLv
reviewed
Dec 2, 2019
@@ -127,7 +127,6 @@ and max thresholds representing the threholds for quantizing the float32 output | |||
|
|||
// TODO(zhangrong): need extra condition check if there's benefited if it's switched on | |||
// Since it's not compute-intensive. | |||
#if 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the TODO
here resolved now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll remove this todo
since this operator is registered as kSupport
quantize mode.
@juliusshufan You may want to see performance numbers with this PR. :) |
xinyu-intel
force-pushed
the
s8_sum_opt_master
branch
from
December 9, 2019 01:06
ed2f7d2
to
f1f6644
Compare
pengzhao-intel
approved these changes
Dec 9, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
cache primitive for int8 eltwise_add operator with dnnl 1.0
@pengzhao-intel @TaoLv @rongzha1
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments