Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Bumping MXNet version to 1.6.0 in base.h for C APIs #16906

Merged
merged 1 commit into from
Nov 26, 2019

Conversation

access2rohit
Copy link
Contributor

@access2rohit access2rohit commented Nov 26, 2019

Description

Bumping MXNet version to 1.6.0 in base.h for C APIs
#16904

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)

@access2rohit
Copy link
Contributor Author

@lanking520 @ptrendx

@ptrendx
Copy link
Member

ptrendx commented Nov 26, 2019

@ChaiBapchya @larroy all those failed builds are because of a hang during compilation, what can we do to diagnose and fix it?

Copy link
Contributor

@samskalicky samskalicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lanking520
Copy link
Member

restarted all the tests

@ChaiBapchya
Copy link
Contributor

@ptrendx prima facie (I could see lots of pipelines timing out) Need to dig deep to find out where exactly was it consuming the most time. In December, we will be revisiting this in greater detail. For now CI is to be kept running...

@access2rohit
Copy link
Contributor Author

@mxnet-label-bot add [pr-awaiting-merge]

@lanking520 lanking520 added the pr-awaiting-merge Review and CI is complete. Ready to Merge label Nov 26, 2019
@lanking520 lanking520 merged commit 121739a into apache:v1.6.x Nov 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants