Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.6.x] Backport #16837 into v1.6.x #16847

Merged
merged 2 commits into from
Nov 22, 2019

Conversation

wuxun-zhang
Copy link
Contributor

@wuxun-zhang wuxun-zhang commented Nov 18, 2019

Description

Backports 16837 to v1.6.x branch.
@pengzhao-intel @TaoLv

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

Copy link
Contributor

@pengzhao-intel pengzhao-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TaoLv TaoLv changed the title Backport #16837 into v1.6.x [v1.6.x] Backport #16837 into v1.6.x Nov 18, 2019
@pengzhao-intel
Copy link
Contributor

retrigger?

@ptrendx
Copy link
Member

ptrendx commented Nov 20, 2019

The failures were caused by the known to be flaky test - I retriggered them.

@ptrendx ptrendx mentioned this pull request Nov 21, 2019
7 tasks
@pengzhao-intel
Copy link
Contributor

Merging now. thanks @ptrendx

@pengzhao-intel pengzhao-intel merged commit 200f0ec into apache:v1.6.x Nov 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants