Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix windows flakiness #16415

Merged
merged 5 commits into from
Oct 10, 2019
Merged

Conversation

reminisce
Copy link
Contributor

@reminisce reminisce commented Oct 9, 2019

Description

Reverts PR Numpy det and slogdet operators #15861 which causes flakiness on windows platforms.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@DickJC123
Copy link
Contributor

Thanks for this effort to get the CI passing again! Looks promising! Sorry to see the unix-cpu pipeline had a network issue and will need a retrigger.

@reminisce reminisce marked this pull request as ready for review October 10, 2019 02:12
@reminisce reminisce requested a review from szha as a code owner October 10, 2019 02:12
@reminisce reminisce changed the title [DO NOT MERGE] Fix windows flakiness Fix windows flakiness Oct 10, 2019
@reminisce reminisce merged commit 9ff644b into apache:master Oct 10, 2019
@junrushao
Copy link
Member

Curious why this could cause flakiness. Could you kindly provide some information? Many thanks!

@reminisce
Copy link
Contributor Author

@junrushao1994 I'm puzzled by the flakiness too. Need to dive deep later to figure out the root cause. It's not obvious from the code displayed here.

@nickguletskii
Copy link
Contributor

Possibly related: #15975

The test for mx.symbol.slogdet is currently disabled.

aaronmarkham pushed a commit to aaronmarkham/incubator-mxnet that referenced this pull request Oct 16, 2019
* Revert "Numpy det and slogdet operators (apache#15861)"

This reverts commit 295fc14.

* Delete non-windows test

* Revert "Numpy Operators: Inner, Outer, vdot (apache#15846)"

This reverts commit 2df3282.

* Revert "Revert "Numpy Operators: Inner, Outer, vdot (apache#15846)""

This reverts commit 79ceaa7.

* Revert "Delete non-windows test"

This reverts commit c915877.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants