Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[DO NOT SQUASH MERGE] NumPy staged PRs #16248

Merged
merged 4 commits into from
Sep 23, 2019
Merged

[DO NOT SQUASH MERGE] NumPy staged PRs #16248

merged 4 commits into from
Sep 23, 2019

Conversation

reminisce
Copy link
Contributor

Description

DO NOT SQUASH COMMITS TO MERGE. We would like to keep the record of the original PR author.

This PR contains four PRs that have been code reviewed and approved. They were originally submitted to the master branch in separate PRs. To avoid triggering CI too many times due to conflict resolution, this PR is created to merge them once for all.

Reference PRs:

  1. [numpy][tvm] rad2deg && deg2rad #16015
  2. [Numpy] operator arctan2 #15890
  3. [numpy] nonzero #15838
  4. [Numpy] operator hypot #15901

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

* change the test code

* add @use_np in test code

* only support float16, float32 and float64.

* fix format error

* remove redundant backslash

* change wrapper in symbol

* delete gpu test

* edit test

* change infer type

* remove redundant **kwargs

* change atol and rtol in test

* edit test shape
* add cpu test and handle 0-dim

* add FGradient with MakeZeroGradNodes

* handle 0-dim and 0-shape and add test on gpu

* add doc

* fix bug in review

* do not use thrust::inclusive_scan on cpu

* fix format error

* edit test and remove gpu test

The output is same as numpy.transpose(numpy.nonzero(x))

* fix error of review

* edit test
* rebase master

* edit test

* add IsIntType to check the input type

* fix error in test

* remove hypot in doc
* fix format error

* change type

* constangt must be tvm.const in tvm and add backward test, do not support float16

* add addto test

* handle 0-dim and 0-size

* add 0-dim test case

* register to npi and add wrapper with doc

* change function name, add infer type

* fix format error

* merge rad2deg to deg2rad

* fix error according to review

* change infer type

* add TVM_OP in test
@reminisce reminisce merged commit 72b4d9b into master Sep 23, 2019
@reminisce reminisce deleted the numpy_staging_prs branch September 23, 2019 19:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants