Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

added check for empty params file and unknown param (not arg/aux) #15917

Merged
merged 7 commits into from
Aug 16, 2019

Conversation

samskalicky
Copy link
Contributor

Description

Fixes error when loading empty params file (fixes #15916)
Added check for unknown params in params file, was silently ignoring before

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@samskalicky samskalicky requested a review from szha as a code owner August 15, 2019 19:13
Copy link
Member

@anirudh2290 anirudh2290 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the additional warning if save_dict is not dict as discussed offline

@samskalicky
Copy link
Contributor Author

Thanks @anirudh2290! Added the additional warning message.

@zachgk for review/merge?

@zachgk zachgk merged commit acc7865 into apache:master Aug 16, 2019
anirudhacharya pushed a commit to anirudhacharya/mxnet that referenced this pull request Aug 20, 2019
…ache#15917)

* added check for empty params file and unknown param (not arg/aux)

* changed exception to warning for unknown params

* removed unnecessary MXNetError import

* added warning message is params is empty

* fixed print

* fixed formatting

* missing paren
samskalicky pushed a commit to samskalicky/incubator-mxnet that referenced this pull request Aug 28, 2019
…ache#15917)

* added check for empty params file and unknown param (not arg/aux)

* changed exception to warning for unknown params

* removed unnecessary MXNetError import

* added warning message is params is empty

* fixed print

* fixed formatting

* missing paren
anirudh2290 pushed a commit that referenced this pull request Aug 28, 2019
…5917)

* added check for empty params file and unknown param (not arg/aux)

* changed exception to warning for unknown params

* removed unnecessary MXNetError import

* added warning message is params is empty

* fixed print

* fixed formatting

* missing paren
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when loading models with no params
3 participants