This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New Website: Remove Old Content [2/3] #15885
Merged
aaronmarkham
merged 26 commits into
apache:master
from
ThomasDelteil:new_website_delete_content
Sep 19, 2019
Merged
New Website: Remove Old Content [2/3] #15885
aaronmarkham
merged 26 commits into
apache:master
from
ThomasDelteil:new_website_delete_content
Sep 19, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Thomas Delteil <thomas.delteil1@gmail.com> Co-authored-by: Aaron Markham <markhama@amazon.com>
Co-authored-by: Thomas Delteil <thomas.delteil1@gmail.com> Co-authored-by: Aaron Markham <markhama@amazon.com>
5 tasks
This allows things to coexist until a following PR deletes this file.
…e_patch license header fixes
add licenses and excludes
Can you rebase onto master to isolate the new commits from the commits that were part of New Website PR 1? |
@zachgk way too many merge conflicts when trying to rebase sorry, let's try that way for now |
…ite_delete_content
aaronmarkham
changed the title
[WIP] New Website: Remove Old Content [2/3]
New Website: Remove Old Content [2/3]
Sep 18, 2019
aaronmarkham
approved these changes
Sep 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Ship it!
zachgk
approved these changes
Sep 18, 2019
anirudh2290
approved these changes
Sep 18, 2019
larroy
pushed a commit
to larroy/mxnet
that referenced
this pull request
Sep 28, 2019
* Adding new website files Co-authored-by: Thomas Delteil <thomas.delteil1@gmail.com> Co-authored-by: Aaron Markham <markhama@amazon.com> * removing old content Co-authored-by: Thomas Delteil <thomas.delteil1@gmail.com> Co-authored-by: Aaron Markham <markhama@amazon.com> * add license header * fixing links and url + css * fixing tutorials * exclude python_docs folder when building prod site This allows things to coexist until a following PR deletes this file. * license header fixes * exclude static site from license header check * exclude static site and sphinx theme * exclude static_site and cpp_docs from sphinx * add licenses and excludes * fix headers * restore file for legacy builds * empty commit to trigger CI * update submodule to correct one * delete website check * add placeholder website check * add placeholder website check, for reals this time * trigger CI * trigger PR
There's a tutorial I was looking for that seems to be removed in this PR, here it is on 1.4.0: https://github.com/apache/incubator-mxnet/blob/1.4.0/docs/tutorials/vision/cnn_visualization.md Where did this get moved to? |
Yes there is a PR to add a few missing tutorials I'll double check this one is included, as soon as the CI is more stable we'll get it in. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This specific commit can be reviewed here in isolation here for better readability: ThomasDelteil#5
This removes the old website
New website visible here: https://mxnet-beta.staged.apache.org/
Merging this will disable website validation on PRs and any updates to the website until the follow-up PR is merged to add CI for the new docs and website: #15883