Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.5.x] Added sub and mul to ONNX->TensorRT conversion (#15344) #15875

Merged
merged 1 commit into from
Aug 16, 2019

Conversation

KellenSunderland
Copy link
Contributor

Description

Added the sub/mul operators to the MXnet -> ONNX conversion, for usage in the ONNX -> tensorRT conversion.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Added ConvertElementwiseSub in nnvm_to_onnx-inl.h / nnvm_to_onnx.cc
  • Added ConvertElementwiseMul in nnvm_to_onnx-inl.h / nnvm_to_onnx.cc
  • Minor: fixed typo in CMakelists

Comments

  • The implementation directly follows ConvertElementwiseAdd.
  • Fixes a bug since these missing operators were registered as TRTcompatible even before this commit.

…5344)

* added sub and mul to ONNX->TensorRT conversion

* add test for elementwise ops in TRT
Copy link
Contributor

@pengzhao-intel pengzhao-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TaoLv TaoLv merged commit 964f288 into apache:v1.5.x Aug 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants