Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Backport][v1.5.x] Fix the bug of MXEnginePushAsyncND and MXEnginePushSyncND #15775

Closed
wants to merge 2 commits into from

Conversation

wkcn
Copy link
Member

@wkcn wkcn commented Aug 7, 2019

Description

Fix the bug of MXEnginePushAsyncND and MXEnginePushSyncND in v1.5.x release

Issue: #15774
master branch: #15751
v1.5.x branch: #15775

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Modify the type of arguments to 'NDArry**'
  • Update the unittest

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@wkcn wkcn changed the title [v1.5.x patch] Fix the bug of MXEnginePushAsyncND and MXEnginePushSyncND [Backport][v1.5.x] Fix the bug of MXEnginePushAsyncND and MXEnginePushSyncND Aug 7, 2019
@wkcn
Copy link
Member Author

wkcn commented Aug 7, 2019

Thank @szha ! The PR will be merged if there is no change in #15751

@wkcn wkcn added the pr-awaiting-merge Review and CI is complete. Ready to Merge label Aug 7, 2019
@TaoLv
Copy link
Member

TaoLv commented Aug 8, 2019 via email

@wkcn
Copy link
Member Author

wkcn commented Aug 8, 2019

@TaoLv Should I reopen a PR created by cherry-pick?

@wkcn
Copy link
Member Author

wkcn commented Aug 8, 2019

I see. Close this PR, and I will reopen a PR committed by cherry-pick : )

@wkcn wkcn closed this Aug 8, 2019
@wkcn wkcn removed the pr-awaiting-merge Review and CI is complete. Ready to Merge label Aug 8, 2019
@wkcn
Copy link
Member Author

wkcn commented Aug 8, 2019

Hi @TaoLv , I have created a new PR #15792 committed by cherry-pick.

@wkcn wkcn deleted the v1.5.x-patch branch August 8, 2019 03:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants