Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-978] Higher Order Gradient Support softsign, hard_sigmoid. #15679

Conversation

kshitij12345
Copy link
Contributor

Description

PR intends to add support for higher order gradient for softsign, hard_sigmoid.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA-978 issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • higher order gradient for a softsign, hard_sigmoid.
  • unit test for the same.

@piyushghai
Copy link
Contributor

Thanks for your contributions @kshitij12345. Can you look into the merge conflicts ?
@mxnet-label-bot Add [Backend, Operator].

@marcoabreu marcoabreu added Backend Issues related to the backend of MXNet Operator labels Jul 31, 2019
…to develop/add-higher-order/softsign-hardsigmoid
@karan6181
Copy link
Contributor

@apeforest @anirudh2290 @anirudhacharya Could you please review this PR? Thanks!

@kshitij12345
Copy link
Contributor Author

I guess we should wait till #15531 is in.

@kshitij12345
Copy link
Contributor Author

@apeforest @larroy @sxjscience Gentle ping for review.

Copy link
Contributor

@apeforest apeforest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Many thanks for your contribution!

@kshitij12345 kshitij12345 deleted the develop/add-higher-order/softsign-hardsigmoid branch June 16, 2021 23:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Backend Issues related to the backend of MXNet Operator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants