This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[MXNET-978] Higher Order Gradient Support softsign
, hard_sigmoid
.
#15679
Closed
kshitij12345
wants to merge
12
commits into
apache:master
from
kshitij12345:develop/add-higher-order/softsign-hardsigmoid
Closed
[MXNET-978] Higher Order Gradient Support softsign
, hard_sigmoid
.
#15679
kshitij12345
wants to merge
12
commits into
apache:master
from
kshitij12345:develop/add-higher-order/softsign-hardsigmoid
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for your contributions @kshitij12345. Can you look into the merge conflicts ? |
…to develop/add-higher-order/softsign-hardsigmoid
@apeforest @anirudh2290 @anirudhacharya Could you please review this PR? Thanks! |
I guess we should wait till #15531 is in. |
@apeforest @larroy @sxjscience Gentle ping for review. |
…to develop/add-higher-order/softsign-hardsigmoid
apeforest
approved these changes
Jan 15, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Many thanks for your contribution!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR intends to add support for higher order gradient for
softsign
,hard_sigmoid
.Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
softsign
,hard_sigmoid
.