-
Notifications
You must be signed in to change notification settings - Fork 6.8k
julia: bump Windows prebult binary version to v1.5.0 #15608
Conversation
iblislin
commented
Jul 19, 2019
- remove file REQUIRE, it's stale for Pkg3.jl
- this patch has been included in the Julia package v1.5.x branch (dmlc/MXNet.jl@73e0fba)
Sorry, but it seems like we're breaking the Apache rules regarding releases and code ownership here. (I know it's nothing new you introduced here, but it just got my attention) Could you elaborate why you're referencing an external repository and explain how the code ownership of the Julia package is looking like exactly. I was under the impression that the Julia package is now completely part of the Apache Incubator and thus the DMLC repository is only acting as mirror for legacy reasons. |
Hi @marcoabreu, the discussion is here: I selected that old MXNet.jl repo as the release channel for Julia package. |
This branch (https://github.com/dmlc/MXNet.jl/tree/v1.5.x) is created by |
Ah I remember, thanks. Go ahead :) |
BTW, if I want to backport this patches to v1.5.x branch, what is the backport process? |
You can choose the target branch when you edit the PR. It's at the top. |
I want this PR get merged into both master and v1.5.x branch. I think it's not possible in single PR... Is there a backport process developed? |
Correct, you have to make two separate prs. As far as the process is define, we only prepend "[1.5.x]" to the PR title and set the target branch. Then we wait for CI to pass and one approval. |
Ah, and we cherry pick commits from master if possible. |
ah, okay! |
I think the CI failures are unrelated. |
- remove file REQUIRE, it's stale for Pkg3.jl
15db992
to
3aba159
Compare
- remove file REQUIRE, it's stale for Pkg3.jl
- remove file REQUIRE, it's stale for Pkg3.jl
* julia: bump window prebult binary version to v1.5.0 (#15608) - remove file REQUIRE, it's stale for Pkg3.jl * update julia install doc (#15609) * julia: fix `mx.forward` kwargs checking (#16138) close dmlc/MXNet.jl#431 * Julia: add API docs back (#16348) `ndarray` and `symbolic-node` have been refactored by splitting into a few files in commits ed83071 and 36a3cb8, but the corresponding document setting for MXNet.jl is not updated yet. List all split source files into the `at_autodoc` setting. Also refer to the `at_autodoc` setting in `julia/docs/src/api/optimizer.md`