This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[MXNET-978] Higher Order Gradient Support arcsinh
, arccosh
.
#15530
Merged
apeforest
merged 7 commits into
apache:master
from
kshitij12345:develop/add-higher-order/arcsinh-arccosh
Sep 30, 2019
Merged
[MXNET-978] Higher Order Gradient Support arcsinh
, arccosh
.
#15530
apeforest
merged 7 commits into
apache:master
from
kshitij12345:develop/add-higher-order/arcsinh-arccosh
Sep 30, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@mxnet-label-bot add [Operator, pr-awaiting-review] |
larroy
reviewed
Jul 16, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % grad_x -> x_grad for consistency.
larroy
reviewed
Jul 16, 2019
unary_bwd<mshadow_op::arcsinh_grad>) | ||
.set_attr<nnvm::FGradient>("FGradient", | ||
[](const nnvm::NodePtr& n, const std::vector<nnvm::NodeEntry>& ograds) { | ||
// ograds[0]: head_grad_grads (dL/dy_grad) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dL/dx_grad ?
…to develop/add-higher-order/arcsinh-arccosh
larroy
approved these changes
Aug 22, 2019
@apeforest Gentle ping for review:) |
larroy
approved these changes
Sep 30, 2019
apeforest
approved these changes
Sep 30, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for your contribution!
@larroy , Can you please check if it is always failing on windows system. I tried running with the failed seed on Ubuntu but the test ran successfully. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR intends to add support for higher order gradient for
arcsinh
,arccosh
.Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
arcsinh
,arccosh
.