This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Add AMP Conversion support for BucketingModule #15528
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@mxnet-label-bot add [Module, Python, pr-work-in-progress] |
anirudh2290
force-pushed
the
lstm_bucketing_amp
branch
from
July 20, 2019 01:05
5cc3059
to
f5ee02d
Compare
anirudh2290
changed the title
[WIP] Add AMP Conversion support for BucketingModule
Add AMP Conversion support for BucketingModule
Jul 20, 2019
larroy
reviewed
Jul 29, 2019
larroy
reviewed
Jul 29, 2019
larroy
reviewed
Jul 29, 2019
samskalicky
reviewed
Jul 29, 2019
samskalicky
approved these changes
Aug 2, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ChaiBapchya
reviewed
Aug 2, 2019
anirudh2290
force-pushed
the
lstm_bucketing_amp
branch
from
August 8, 2019 19:42
7da713b
to
306e2df
Compare
anirudh2290
added
pr-awaiting-merge
Review and CI is complete. Ready to Merge
pr-awaiting-review
PR is waiting for code review
and removed
pr-work-in-progress
PR is still work in progress
labels
Aug 19, 2019
nswamy
approved these changes
Aug 26, 2019
apeforest
approved these changes
Aug 26, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Module
pr-awaiting-merge
Review and CI is complete. Ready to Merge
pr-awaiting-review
PR is waiting for code review
Python
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments