-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Custom Operator Profiling Enhancement #15210
Conversation
@mxnet-label-bot add [Operator, pr-work-in-progress] |
There are no test cases associated with this new feature introduction. Please add test cases. |
Even if the PR is WIP add the description and explain briefly what feature are you adding to MXNet profiler and show how it adds value over existing profiler |
Please add more description to this PR. What was done, what was tested, any limitationn |
I have added a new test in test_profiler.py. |
Can you more test cases like: Try to include python processing code in all the above cases |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. Lets wait for the CI. Also @arcadiaphy 's review constitutes a veto so I will wait for him to take another look before moving forward with this PR.
@arcadiaphy looks like your comments have been addressed. Can you please take another look ? |
* working version * style fix * several fixes * resolve issues in the comments * revert to using thread-safe Get() for singleton class CustomOpProfiler * indentation * Now supports Naive Engine * style fix * tidiness * tests added * style fix * add a new test case which has multiple custom ops * testcases fix * fix * fix style * minor naive engine fix * simplify some branching logic * better desing style * fix * fix * fix * fix * fix * fix * add isprofiling check to onCustomStart * fix * rename dummy_wait * fix conflict * improve test * fix * fix test cases * fix test cases * fix testcases * revert back to reduce overhead * fix style * Re-Trigger build * rename var * Re-Trigger build
* working version * style fix * several fixes * resolve issues in the comments * revert to using thread-safe Get() for singleton class CustomOpProfiler * indentation * Now supports Naive Engine * style fix * tidiness * tests added * style fix * add a new test case which has multiple custom ops * testcases fix * fix * fix style * minor naive engine fix * simplify some branching logic * better desing style * fix * fix * fix * fix * fix * fix * add isprofiling check to onCustomStart * fix * rename dummy_wait * fix conflict * improve test * fix * fix test cases * fix test cases * fix testcases * revert back to reduce overhead * fix style * Re-Trigger build * rename var * Re-Trigger build
This reverts commit 92fce90.
Description
fix: #15241
I have implemented the new feature.
Need to add test cases.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.