-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[MXNET-1411] solve pylint error issue#14851 #15113
[MXNET-1411] solve pylint error issue#14851 #15113
Conversation
@mxnet-label-bot add [pr-awaiting-review] |
Thanks for your contribution @cchung100m. |
Hi @stu1130 Here is the pylint check, please help to review the result, thanks. |
Hi @stu1130, @marcoabreu I cannot pass the Jenkins' sanity check job, I would appreciate if you can give me suggestions to solve it, thanks.
|
|
Hi @marcoabreu Thanks for the suggestions. I improve the PR by solving pylint error R1720, but still fail with CI job 'sanity',
However, I check the test_utils.py with the following command but didn't find the error.
I would appreciate if you can give me more clues, thanks :) |
Hi @stu1130, @marcoabreu I cannot find the error "The if expression can be replaced with 'not test'" in Module mxnet.test_utils. I would appreciate if you can give me suggestions to solve it, thanks. |
@stu1130 could you help? thanks! |
@stu1130, @marcoabreu Could you please help the author on resolving the issue? Thanks! |
Hi, it could be possible that you are running an old version of pylint. Could you check that? Sorry for the delay |
… in test_utils.py
… for _translation_utils.py
… for _export_helper.py
… for test_utils.py
… for detection.py
…test)' (simplifiable-if-expression)
b576ec9
to
457e77f
Compare
@marcoabreu |
* fix pylint error: no-else-raise in _export_helper.py * fix pylint error: no-else-raise in _translation_utils.py * fix pylint error: Bad option value 'no-else-raise' (bad-option-value) in vocab.py * fix pylint error: Bad option value 'no-else-raise' (bad-option-value) in trainer.py * fix pylint error: Bad option value 'no-else-raise' (bad-option-value) in utils.py * fix pylint error: Bad option value 'no-else-raise' (bad-option-value) in detection.py * fix pylint error: Bad option value 'no-else-raise' (bad-option-value) in image.py * fix pylint error: Bad option value 'no-else-raise' (bad-option-value) in model.py * fix pylint error: Bad option value 'no-else-raise' (bad-option-value) in sparse.py * fix pylint error: Bad option value 'no-else-raise' (bad-option-value) in test_utils.py * fix pylint error: R1720: Unnecessary else after raise (no-else-raise) for vocab.py * fix pylint error: R1720: Unnecessary else after raise (no-else-raise) for model.py * fix pylint error: R1720: Unnecessary else after raise (no-else-raise) for _translation_utils.py * fix pylint error: R1720: Unnecessary else after raise (no-else-raise) for _export_helper.py * fix pylint error: R1720: Unnecessary else after raise (no-else-raise) for test_utils.py * fix pylint error: R1720: Unnecessary else after raise (no-else-raise) for image.py * fix pylint error: R1720: Unnecessary else after raise (no-else-raise) for trainer.py * fix pylint error: R1720: Unnecessary else after raise (no-else-raise) for detection.py * fix pylint error: R1720: Unnecessary else after raise (no-else-raise) for utils.py * fix pylint error: R1720: Unnecessary else after raise (no-else-raise) for sparse.py * fix pylint error:R1719: The if expression can be replaced with 'bool(test)' (simplifiable-if-expression)
Description
Pylint error 'Bad option value 'no-else-raise' (bad-option-value)' was reported by issue 14851, therefore, I check the code and remove the statement '# pylint: disable=redefined-variable-type' for solving the issue.
My environment:
(venv) cch:incubator-mxnet cch$ pylint --version
pylint 2.1.1
astroid 2.1.0
Python 3.5.1 (default, Jan 22 2016, 17:08:33)
[GCC 4.2.1 Compatible Apple LLVM 6.0 (clang-600.0.57)]
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments