This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Fix unary operator ceil/floor/trunc when data type is integer #14251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@mxnet-label-bot add [pr-work-in-progress] |
szha
reviewed
Mar 6, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix. It would be great to test for it.
@apeforest Could you please add a test as suggested by @szha ? |
@apeforest Gentle ping... |
@apeforest Thanks for your contribution! Did you get a chance to add a test ? |
apeforest
changed the title
[WIP] Fix unary operator ceil/floor/trunc when data type is integer
Fix unary operator ceil/floor/trunc when data type is integer
Sep 5, 2019
apeforest
force-pushed
the
bugfix/issue13220
branch
from
September 5, 2019 21:32
d939afc
to
574bc64
Compare
apeforest
added
pr-awaiting-review
PR is waiting for code review
and removed
pr-work-in-progress
PR is still work in progress
labels
Sep 5, 2019
larroy
approved these changes
Sep 5, 2019
eric-haibin-lin
approved these changes
Sep 6, 2019
ChaiBapchya
approved these changes
Sep 6, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
thx for the fix |
gyshi
pushed a commit
to gyshi/incubator-mxnet
that referenced
this pull request
Sep 7, 2019
…#14251) * fix integer precision loss due to casting to float * add test * update comment
gyshi
pushed a commit
to gyshi/incubator-mxnet
that referenced
this pull request
Sep 7, 2019
…#14251) * fix integer precision loss due to casting to float * add test * update comment
larroy
pushed a commit
to larroy/mxnet
that referenced
this pull request
Sep 28, 2019
…#14251) * fix integer precision loss due to casting to float * add test * update comment
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Many operators implicitly cast data to float and return inaccurate results. This PR fixes #13220.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments