This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Don't override global warnings filter #12245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently import mxnet causes warnings.filterwarnings('default', category=DeprecationWarning) to be executed.
This is very bad, as there are valid use cases where our users may have decided to filter out DeprecationWarning and we should not overwrite their configuration.
|
This was added in a273078 @piiswrong do you mind if we remove it now (ie. merge this PR) given the issues it is causing? |
XinYao1994
pushed a commit
to XinYao1994/incubator-mxnet
that referenced
this pull request
Aug 29, 2018
Currently import mxnet causes warnings.filterwarnings('default', category=DeprecationWarning) to be executed.
This is very bad, as there are valid use cases where our users may have decided to filter out DeprecationWarning and we should not overwrite their configuration.
anirudh2290
pushed a commit
to anirudh2290/mxnet
that referenced
this pull request
Sep 19, 2018
Currently import mxnet causes warnings.filterwarnings('default', category=DeprecationWarning) to be executed.
This is very bad, as there are valid use cases where our users may have decided to filter out DeprecationWarning and we should not overwrite their configuration.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently import mxnet causes warnings.filterwarnings('default', category=DeprecationWarning) to be executed.
This is very bad, as there are valid use cases where our users may have decided to filter out DeprecationWarning and we should not overwrite their configuration.
It is also not always possible for users to change the warnings filter after mxnet has changed it. Consider a package that relies on mxnet (such as https://github.com/dmlc/gluon-nlp ) but also imports third-party packages that may raise warnings. If now gluon-nlp is imported, mxnet will overwrite the warnings filter and the user has no option to change it back to whatever settings he needs before gluon-nlp goes on to import other packages that may raise warnings.
Changes
Comments
@szha This breaks our notebooks for KDD18
@Roshrini Can we get this into mxnet 1.3 please?