This repository was archived by the owner on Nov 17, 2023. It is now read-only.
fix flasky unittest for deformable psroi pooling #12178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoabreu
suggested changes
Aug 15, 2018
| # By now we only have gpu implementation | ||
| if default_context().device_type == 'gpu': | ||
| check_numeric_gradient(op, [im_data, rois_data, offset_data], rtol=rtol, atol=atol, | ||
| grad_nodes=grad_nodes, ctx=mx.gpu(0)) | ||
| grad_nodes=grad_nodes, ctx=mx.gpu(1)) |
There was a problem hiding this comment.
Sorry, this is not intentional. I fixed it already.
|
The changes looks good to me and have verified it locally for 2500 runs with random seeds. |
sandeep-krishnamurthy
added
Flaky
pr-awaiting-merge
sandeep-krishnamurthy
approved these changes
Aug 15, 2018
|
@marcoabreu - Your concerns are addressed. This is ready to be merged. |
|
@marcoabreu Your concerns are addressed. Could you please merge this PR? |
marcoabreu
added a commit
that referenced
this pull request
Aug 17, 2018
This reverts commit 2b4d512.
piyushghai
added a commit
to piyushghai/incubator-mxnet
that referenced
this pull request
Aug 17, 2018
This reverts commit 2b4d512.
|
Everyone, please check #11713 |
XinYao1994
pushed a commit
to XinYao1994/incubator-mxnet
that referenced
this pull request
Aug 29, 2018
* fix flasky unittest for deformable psroi pooling * Fix incorrect gpu specification
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to fix the problem raised by issue #11713.
Checklist
Essentials
Changes
The deformable ps roi pooling operator includes several corner cases which the function is not differentiable. Therefore during the unittest, we need to add some check to ensure the input values are within the smooth regions.
Comments
The issue and solution are discussed with @ankkhedia, @sandeep-krishnamurthy, @YuwenXiong and the fix is ran by @ankkhedia for about 2500 times on his local machine.
@ankkhedia could you help review it?