Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

batchnorm falls back for sparse arrays. #11473

Merged
merged 3 commits into from
Jul 2, 2018
Merged

batchnorm falls back for sparse arrays. #11473

merged 3 commits into from
Jul 2, 2018

Conversation

zheng-da
Copy link
Contributor

@zheng-da zheng-da commented Jun 28, 2018 •
edited
Loading

Description

When one of the inputs is a sparse array, BatchNorm should fall back, instead of calling MKLDNN BatchNorm.
#11448

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@zheng-da
Copy link
Contributor Author

@haojin2 @eric-haibin-lin @azai91

eric-haibin-lin
eric-haibin-lin reviewed Jun 28, 2018
View reviewed changes
Copy link
Member

@eric-haibin-lin eric-haibin-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we enable some test?

@haojin2
Copy link
Contributor

haojin2 commented Jun 29, 2018

I think we do need some extra checks for this to verify that this works

@zheng-da
Copy link
Contributor Author

zheng-da commented Jul 1, 2018

@eric-haibin-lin any more comments with this PR?

@eric-haibin-lin eric-haibin-lin merged commit c5035b6 into apache:master Jul 2, 2018
@zheng-da zheng-da deleted the fix_mkldnn_sparse branch July 5, 2018 06:18
XinYao1994 pushed a commit to XinYao1994/incubator-mxnet that referenced this pull request Aug 29, 2018
@zheng-da @eric-haibin-lin
batchnorm falls back for sparse arrays. (apache#11473)
5ee2872 
* batchnorm fall back.

* add test

* fix.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eric-haibin-lin eric-haibin-lin eric-haibin-lin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zheng-da @haojin2 @eric-haibin-lin