This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why didn't testing catch this? all tests in test_operator are automatically run again with gpu in test_operator_gpu |
i was wondering about this as well. I'll look at the tests tomorrow. |
haojin2
reviewed
May 10, 2018
@@ -104,5 +104,9 @@ NNVM_REGISTER_OP(norm) | |||
.set_attr<FCompute>("FCompute<gpu>", L2NormCompute<gpu>) | |||
.set_attr<FComputeEx>("FComputeEx<gpu>", L2NormComputeEx<gpu>); | |||
|
|||
NNVM_REGISTER_OP(_backward_norm) | |||
.set_attr<FCompute>("FCompute<cpu>", L2NormGradCompute<gpu>) | |||
.set_attr<FComputeEx>("FComputeEx<cpu>", L2NormGradComputeEx<gpu>); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be FCompute<gpu>
and FComputeEx<gpu>
?
@piiswrong I think we should get this fix in first. @zheng-da could you create an issue or something to keep track of the test issue? |
I am still concerned that unit tests didn't catch this |
jinhuang415
pushed a commit
to jinhuang415/incubator-mxnet
that referenced
this pull request
May 29, 2018
* support gpu. * Fix.
rahul003
pushed a commit
to rahul003/mxnet
that referenced
this pull request
Jun 4, 2018
* support gpu. * Fix.
zheng-da
added a commit
to zheng-da/incubator-mxnet
that referenced
this pull request
Jun 28, 2018
* support gpu. * Fix.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(Brief description on what this PR is about)
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.