Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

support L2Norm backward for GPU. #10874

Merged
merged 2 commits into from
May 13, 2018
Merged

support L2Norm backward for GPU. #10874

merged 2 commits into from
May 13, 2018

Conversation

zheng-da
Copy link
Contributor

@zheng-da zheng-da commented May 9, 2018

Description

(Brief description on what this PR is about)

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@piiswrong
Copy link
Contributor

Why didn't testing catch this? all tests in test_operator are automatically run again with gpu in test_operator_gpu

@zheng-da
Copy link
Contributor Author

i was wondering about this as well. I'll look at the tests tomorrow.

@@ -104,5 +104,9 @@ NNVM_REGISTER_OP(norm)
.set_attr<FCompute>("FCompute<gpu>", L2NormCompute<gpu>)
.set_attr<FComputeEx>("FComputeEx<gpu>", L2NormComputeEx<gpu>);

NNVM_REGISTER_OP(_backward_norm)
.set_attr<FCompute>("FCompute<cpu>", L2NormGradCompute<gpu>)
.set_attr<FComputeEx>("FComputeEx<cpu>", L2NormGradComputeEx<gpu>);
Copy link
Contributor

@haojin2 haojin2 May 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be FCompute<gpu> and FComputeEx<gpu>?

@szha
Copy link
Member

szha commented May 13, 2018

@piiswrong I think we should get this fix in first. @zheng-da could you create an issue or something to keep track of the test issue?

@szha szha merged commit 8b53a3d into apache:master May 13, 2018
@eric-haibin-lin
Copy link
Member

I am still concerned that unit tests didn't catch this

jinhuang415 pushed a commit to jinhuang415/incubator-mxnet that referenced this pull request May 29, 2018
rahul003 pushed a commit to rahul003/mxnet that referenced this pull request Jun 4, 2018
zheng-da added a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 28, 2018
@zheng-da zheng-da deleted the norm_back_gpu branch July 5, 2018 06:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants