-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[MXNET-357] New Scala API Design (Symbol) #10660
Changes from 22 commits
23082eb
9b74fc9
2485146
e61e13a
ff4e24e
704be92
eae7bd6
8de007d
51581e3
e370c70
6d7d4bc
c1cbf16
0d34b94
4268c7e
b6fe942
f3b1d96
5c05c8d
006d3b5
0dd3ee1
80753d6
57984a2
e836480
788ddde
ba926fc
0e8a174
c194066
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one or more | ||
* contributor license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright ownership. | ||
* The ASF licenses this file to You under the Apache License, Version 2.0 | ||
* (the "License"); you may not use this file except in compliance with | ||
* the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
package org.apache.mxnet | ||
@AddSymbolAPIs(false) | ||
object SymbolAPI { | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -37,7 +37,11 @@ object Base { | |
|
||
@throws(classOf[UnsatisfiedLinkError]) | ||
private def tryLoadInitLibrary(): Unit = { | ||
val baseDir = System.getProperty("user.dir") + "/init-native" | ||
// val baseDir = System.getProperty("user.dir") + "/init-native" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. remove this line. |
||
var baseDir = System.getProperty("user.dir") + "/init-native" | ||
if (System.getenv().containsKey("BASEDIR")) { | ||
baseDir = sys.env("BASEDIR") | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. what are you expecting BASEDIR variable to be? I think you should have a else There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. BASEDIR locate in the pom file (set as an environment variable) which determine the current base directory. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. for system environment var, better to specify it is mxnet-related, e.g., MXNET_SCALA_MACRO_BASEDIR or something like it. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done |
||
val os = System.getProperty("os.name") | ||
// ref: http://lopica.sourceforge.net/os.html | ||
if (os.startsWith("Linux")) { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment a bit for this placeholder.