GH-618: Fix reading an OpenSshCertificate from a Buffer #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Buffer.getBytesConsumed() is broken. It'll return wrong data for buffers created on a slice of an array not starting at zero. Using it in OpenSSHCertPublicKeyParser will return data before the raw certificate in the buffer if that raw certificate is not the first thing in the buffer. Fix this by adding a Buffer.getBytesConsumed(int from) method, and use that in OpenSSHCertPublicKeyParser. Bug: apache#618
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buffer.getBytesConsumed()is broken. It'll return wrong data for buffers created on a slice of an array not starting at zero. Using it inOpenSSHCertPublicKeyParserwill return data before the raw certificate in the buffer if that raw certificate is not the first thing in the buffer.Fix this by adding a
Buffer.getBytesConsumed(int from)method, and use that inOpenSSHCertPublicKeyParser.Fixes #618.