Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Android-specific exception message when finding user home #580

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

ShellWen
Copy link
Contributor

@ShellWen ShellWen commented Aug 9, 2024

In the Android world, there is no concept similar to a home directory.
That is to say System.getProperty("user.home") is always null.
This PR can guide developer who target Android to add their own home directory implementation by modifying the exception message.

@tomaswolf
Copy link
Member

Needs formatting (see CI build output).

@ShellWen ShellWen force-pushed the fix/android-user-home branch from 6cfccdc to 3dd44a8 Compare August 18, 2024 00:00
@ShellWen
Copy link
Contributor Author

Sorry for mistake. Please check again. 😉

@tomaswolf
Copy link
Member

Still fails. The order of imports is wrong.

If you run a maven build locally it should format as required. Then amend your commit and force push.

@ShellWen ShellWen force-pushed the fix/android-user-home branch from 3dd44a8 to b50fff3 Compare August 18, 2024 12:42
@ShellWen
Copy link
Contributor Author

All checks have passed. Could you please check again?

@tomaswolf tomaswolf merged commit 40a08a4 into apache:master Aug 22, 2024
7 checks passed
@tomaswolf
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants