Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require JDK 17 at build time (fixes #536) #537

Merged
merged 6 commits into from
Jul 26, 2024
Merged

Require JDK 17 at build time (fixes #536) #537

merged 6 commits into from
Jul 26, 2024

Conversation

gnodet
Copy link
Contributor

@gnodet gnodet commented Jul 23, 2024 •
edited
Loading

Fixes #536

@gnodet gnodet added this to the 2.14.0 milestone Jul 23, 2024
@gnodet gnodet force-pushed the i536-require-jdk11 branch from 7caac2f to 3dd86cf Compare July 25, 2024 07:55
@gnodet gnodet changed the title Upgrade parent to apache:43, require JDK 11 at build time and upgrade a few plugins (fixes #536) Upgrade parent to apache:43, require JDK 21 at build time and upgrade a few plugins (fixes #536) Jul 25, 2024
@gnodet gnodet mentioned this pull request Jul 25, 2024
Closed
@gnodet gnodet changed the title Upgrade parent to apache:43, require JDK 21 at build time and upgrade a few plugins (fixes #536) Upgrade parent to apache:43, require JDK 17 at build time and upgrade a few plugins (fixes #536) Jul 25, 2024
@gnodet gnodet force-pushed the i536-require-jdk11 branch from b24db54 to 18e7b01 Compare July 25, 2024 09:06
@gnodet gnodet changed the title Upgrade parent to apache:43, require JDK 17 at build time and upgrade a few plugins (fixes #536) Require JDK 17 at build time (fixes #536) Jul 25, 2024
tomaswolf
tomaswolf reviewed Jul 25, 2024
View reviewed changes
pom.xml Show resolved Hide resolved
@gnodet gnodet merged commit 9dcb788 into apache:master Jul 26, 2024
7 checks passed
@gnodet gnodet deleted the i536-require-jdk11 branch July 26, 2024 06:41
@tomaswolf
Copy link
Member

@gnodet: snapshot deployment fails with

Error: Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.3.0:check (verify-style) on project sshd: Failed during checkstyle execution: Unable to find configuration file at location: ${session.rootDirectory}/sshd-checkstyle.xml: Could not find resource '${session.rootDirectory}/sshd-checkstyle.xml'. -> [Help 1]

@gnodet
Copy link
Contributor Author

gnodet commented Jul 26, 2024 •
edited
Loading

@gnodet: snapshot deployment fails with

Error: Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.3.0:check (verify-style) on project sshd: Failed during checkstyle execution: Unable to find configuration file at location: ${session.rootDirectory}/sshd-checkstyle.xml: Could not find resource '${session.rootDirectory}/sshd-checkstyle.xml'. -> [Help 1]

It requires maven 3.9.x. Where is the job configured ?

[edit] but that's weird, the maven-enforcer-plugin should make sure Maven 3.9.8 is used...

@tomaswolf
Copy link
Member

Deployment is in master-build.yaml. Does that need the extra maven-setup step now, too? Where is that session.rootDirectory coming from?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaswolf tomaswolf tomaswolf left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.14.0
Development

Successfully merging this pull request may close these issues.

Require JDK 17 for building
2 participants
@gnodet @tomaswolf