Fix call to SimpleLoggerFactory.reset method #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ke sure we get the right instance to reset, as SimpleLoggerFactory.INSTANCE is not actually used by slf4j-simple's StaticLoggerBinder) and remove temporary reflection workaround
rosti-il
added a commit
to rosti-il/maven
that referenced
this pull request
Jan 22, 2020
deutschebank-sync
pushed a commit
to deutschebank/maven
that referenced
this pull request
Aug 12, 2021
…en-3.6.3 to MNG-7129/maven-3.6.3-incremental
Squashed commit of the following:
commit 21c620a34ddbbf84b3c44014b069a7b222cf91a7
Author: Maximilian Novikov <maximilian.novikov@db.com>
Date: Tue Aug 10 19:41:41 2021 +0200
Merge pull request apache#3 in ABFX/maven-forked from code-cleanup-2 to incremental-maven-3.6.3
Squashed commit of the following:
commit 3401739ec9eb957fb03887f6a3c24477c9c3327b
Author: Alexander Ashitkin <alexander.ashitkin@db.com>
Date: Tue Aug 10 13:37:13 2021 -0400
cleanup db specifics
commit 5d32f00559951445ecaf7d5ec4d847541c10e7e9
Author: Alexander Ashitkin <alexander.ashitkin@db.com>
Date: Tue Aug 10 11:05:28 2021 -0400
cleanup db specifics
commit fcec28f82c0d447de64032c610b39fa75bb344b0
Merge: 6fd401af2 5b0dc1858
Author: Alexander Ashitkin <alexander.ashitkin@db.com>
Date: Mon Aug 9 13:22:16 2021 +0100
Pull request apache#9: Remote cache setup
Merge in BND/maven-forked from feature/remote-cache-setup to incremental-maven-3.6.3
* commit '5b0dc1858cf4ca499502f0741b2f3bf2ac55530c':
remote cache setup - fail fast, baseline build, diff reporting, documentation.
commit 5b0dc1858cf4ca499502f0741b2f3bf2ac55530c
Author: Alexander Ashitkin <alexander.ashitkin@db.com>
Date: Mon Mar 22 03:30:03 2021 +0100
remote cache setup - fail fast, baseline build, diff reporting, documentation.
commit 6fd401af285692df568312ee66ee00edfe21f1cc
Author: Maximilian Novikov <maximilian.novikov@db.com>
Date: Tue Apr 13 17:36:49 2021 +0100
Pull request apache#8: Incremental Maven - added non-overrideable cache entries
Merge in BND/maven-forked from non-overritable-build-info to incremental-maven-3.6.3
Squashed commit of the following:
commit 405bbef8a59cabc0b83e9a64717f65fbd6fb9e3d
Author: maximilian.novikov@db.com <maximilian.novikov@db.com>
Date: Mon Apr 12 20:18:27 2021 +0200
Incremental Maven - added non-overrideable cache entries - review fixes
commit 197704672756e558fb3521e16859d0be324044b8
Author: maximilian.novikov@db.com <maximilian.novikov@db.com>
Date: Fri Apr 9 11:35:48 2021 +0200
Incremental Maven - added non-overrideable cache entries
commit 64c4b1f5cbdf920ad43560f34cc5be56d4557acf
Author: Alexander Ashitkin <alexander.ashitkin@db.com>
Date: Tue Mar 9 04:10:20 2021 +0100
injected version
commit 727e507ae2fd90dce7011f3f1c76eb4969577d5e
Author: maximilian.novikov@db.com <maximilian.novikov@db.com>
Date: Wed Jan 13 16:17:25 2021 +0100
Incremental Maven - Java 11 fix
commit b2f297566d5afcb0a285985cb5540685a28cafec
Author: maximilian.novikov@db.com <maximilian.novikov@db.com>
Date: Tue Jan 12 14:10:08 2021 +0100
Incremental Maven - initial commit
hboutemy
pushed a commit
that referenced
this pull request
Sep 8, 2021
….3 to MNG-7129/maven-3.6.3-incremental Squashed commit of the following: commit 21c620a34ddbbf84b3c44014b069a7b222cf91a7 Author: Maximilian Novikov <maximilian.novikov@db.com> Date: Tue Aug 10 19:41:41 2021 +0200 Merge pull request #3 in ABFX/maven-forked from code-cleanup-2 to incremental-maven-3.6.3 Squashed commit of the following: commit 3401739ec9eb957fb03887f6a3c24477c9c3327b Author: Alexander Ashitkin <alexander.ashitkin@db.com> Date: Tue Aug 10 13:37:13 2021 -0400 cleanup db specifics commit 5d32f00559951445ecaf7d5ec4d847541c10e7e9 Author: Alexander Ashitkin <alexander.ashitkin@db.com> Date: Tue Aug 10 11:05:28 2021 -0400 cleanup db specifics commit fcec28f82c0d447de64032c610b39fa75bb344b0 Merge: 6fd401af2 5b0dc1858 Author: Alexander Ashitkin <alexander.ashitkin@db.com> Date: Mon Aug 9 13:22:16 2021 +0100 Pull request #9: Remote cache setup Merge in BND/maven-forked from feature/remote-cache-setup to incremental-maven-3.6.3 * commit '5b0dc1858cf4ca499502f0741b2f3bf2ac55530c': remote cache setup - fail fast, baseline build, diff reporting, documentation. commit 5b0dc1858cf4ca499502f0741b2f3bf2ac55530c Author: Alexander Ashitkin <alexander.ashitkin@db.com> Date: Mon Mar 22 03:30:03 2021 +0100 remote cache setup - fail fast, baseline build, diff reporting, documentation. commit 6fd401af285692df568312ee66ee00edfe21f1cc Author: Maximilian Novikov <maximilian.novikov@db.com> Date: Tue Apr 13 17:36:49 2021 +0100 Pull request #8: Incremental Maven - added non-overrideable cache entries Merge in BND/maven-forked from non-overritable-build-info to incremental-maven-3.6.3 Squashed commit of the following: commit 405bbef8a59cabc0b83e9a64717f65fbd6fb9e3d Author: maximilian.novikov@db.com <maximilian.novikov@db.com> Date: Mon Apr 12 20:18:27 2021 +0200 Incremental Maven - added non-overrideable cache entries - review fixes commit 197704672756e558fb3521e16859d0be324044b8 Author: maximilian.novikov@db.com <maximilian.novikov@db.com> Date: Fri Apr 9 11:35:48 2021 +0200 Incremental Maven - added non-overrideable cache entries commit 64c4b1f5cbdf920ad43560f34cc5be56d4557acf Author: Alexander Ashitkin <alexander.ashitkin@db.com> Date: Tue Mar 9 04:10:20 2021 +0100 injected version commit 727e507ae2fd90dce7011f3f1c76eb4969577d5e Author: maximilian.novikov@db.com <maximilian.novikov@db.com> Date: Wed Jan 13 16:17:25 2021 +0100 Incremental Maven - Java 11 fix commit b2f297566d5afcb0a285985cb5540685a28cafec Author: maximilian.novikov@db.com <maximilian.novikov@db.com> Date: Tue Jan 12 14:10:08 2021 +0100 Incremental Maven - initial commit
gnodet
pushed a commit
that referenced
this pull request
Nov 10, 2021
….3 to MNG-7129/maven-3.6.3-incremental Squashed commit of the following: commit 21c620a34ddbbf84b3c44014b069a7b222cf91a7 Author: Maximilian Novikov <maximilian.novikov@db.com> Date: Tue Aug 10 19:41:41 2021 +0200 Merge pull request #3 in ABFX/maven-forked from code-cleanup-2 to incremental-maven-3.6.3 Squashed commit of the following: commit 3401739ec9eb957fb03887f6a3c24477c9c3327b Author: Alexander Ashitkin <alexander.ashitkin@db.com> Date: Tue Aug 10 13:37:13 2021 -0400 cleanup db specifics commit 5d32f00559951445ecaf7d5ec4d847541c10e7e9 Author: Alexander Ashitkin <alexander.ashitkin@db.com> Date: Tue Aug 10 11:05:28 2021 -0400 cleanup db specifics commit fcec28f82c0d447de64032c610b39fa75bb344b0 Merge: 6fd401af2 5b0dc1858 Author: Alexander Ashitkin <alexander.ashitkin@db.com> Date: Mon Aug 9 13:22:16 2021 +0100 Pull request #9: Remote cache setup Merge in BND/maven-forked from feature/remote-cache-setup to incremental-maven-3.6.3 * commit '5b0dc1858cf4ca499502f0741b2f3bf2ac55530c': remote cache setup - fail fast, baseline build, diff reporting, documentation. commit 5b0dc1858cf4ca499502f0741b2f3bf2ac55530c Author: Alexander Ashitkin <alexander.ashitkin@db.com> Date: Mon Mar 22 03:30:03 2021 +0100 remote cache setup - fail fast, baseline build, diff reporting, documentation. commit 6fd401af285692df568312ee66ee00edfe21f1cc Author: Maximilian Novikov <maximilian.novikov@db.com> Date: Tue Apr 13 17:36:49 2021 +0100 Pull request #8: Incremental Maven - added non-overrideable cache entries Merge in BND/maven-forked from non-overritable-build-info to incremental-maven-3.6.3 Squashed commit of the following: commit 405bbef8a59cabc0b83e9a64717f65fbd6fb9e3d Author: maximilian.novikov@db.com <maximilian.novikov@db.com> Date: Mon Apr 12 20:18:27 2021 +0200 Incremental Maven - added non-overrideable cache entries - review fixes commit 197704672756e558fb3521e16859d0be324044b8 Author: maximilian.novikov@db.com <maximilian.novikov@db.com> Date: Fri Apr 9 11:35:48 2021 +0200 Incremental Maven - added non-overrideable cache entries commit 64c4b1f5cbdf920ad43560f34cc5be56d4557acf Author: Alexander Ashitkin <alexander.ashitkin@db.com> Date: Tue Mar 9 04:10:20 2021 +0100 injected version commit 727e507ae2fd90dce7011f3f1c76eb4969577d5e Author: maximilian.novikov@db.com <maximilian.novikov@db.com> Date: Wed Jan 13 16:17:25 2021 +0100 Incremental Maven - Java 11 fix commit b2f297566d5afcb0a285985cb5540685a28cafec Author: maximilian.novikov@db.com <maximilian.novikov@db.com> Date: Tue Jan 12 14:10:08 2021 +0100 Incremental Maven - initial commit
gnodet
pushed a commit
to gnodet/maven
that referenced
this pull request
Feb 8, 2022
…en-3.6.3 to MNG-7129/maven-3.6.3-incremental
Squashed commit of the following:
commit 21c620a34ddbbf84b3c44014b069a7b222cf91a7
Author: Maximilian Novikov <maximilian.novikov@db.com>
Date: Tue Aug 10 19:41:41 2021 +0200
Merge pull request #3 in ABFX/maven-forked from code-cleanup-2 to incremental-maven-3.6.3
Squashed commit of the following:
commit 3401739ec9eb957fb03887f6a3c24477c9c3327b
Author: Alexander Ashitkin <alexander.ashitkin@db.com>
Date: Tue Aug 10 13:37:13 2021 -0400
cleanup db specifics
commit 5d32f00559951445ecaf7d5ec4d847541c10e7e9
Author: Alexander Ashitkin <alexander.ashitkin@db.com>
Date: Tue Aug 10 11:05:28 2021 -0400
cleanup db specifics
commit fcec28f82c0d447de64032c610b39fa75bb344b0
Merge: 6fd401af2 5b0dc1858
Author: Alexander Ashitkin <alexander.ashitkin@db.com>
Date: Mon Aug 9 13:22:16 2021 +0100
Pull request apache#9: Remote cache setup
Merge in BND/maven-forked from feature/remote-cache-setup to incremental-maven-3.6.3
* commit '5b0dc1858cf4ca499502f0741b2f3bf2ac55530c':
remote cache setup - fail fast, baseline build, diff reporting, documentation.
commit 5b0dc1858cf4ca499502f0741b2f3bf2ac55530c
Author: Alexander Ashitkin <alexander.ashitkin@db.com>
Date: Mon Mar 22 03:30:03 2021 +0100
remote cache setup - fail fast, baseline build, diff reporting, documentation.
commit 6fd401af285692df568312ee66ee00edfe21f1cc
Author: Maximilian Novikov <maximilian.novikov@db.com>
Date: Tue Apr 13 17:36:49 2021 +0100
Pull request apache#8: Incremental Maven - added non-overrideable cache entries
Merge in BND/maven-forked from non-overritable-build-info to incremental-maven-3.6.3
Squashed commit of the following:
commit 405bbef8a59cabc0b83e9a64717f65fbd6fb9e3d
Author: maximilian.novikov@db.com <maximilian.novikov@db.com>
Date: Mon Apr 12 20:18:27 2021 +0200
Incremental Maven - added non-overrideable cache entries - review fixes
commit 197704672756e558fb3521e16859d0be324044b8
Author: maximilian.novikov@db.com <maximilian.novikov@db.com>
Date: Fri Apr 9 11:35:48 2021 +0200
Incremental Maven - added non-overrideable cache entries
commit 64c4b1f5cbdf920ad43560f34cc5be56d4557acf
Author: Alexander Ashitkin <alexander.ashitkin@db.com>
Date: Tue Mar 9 04:10:20 2021 +0100
injected version
commit 727e507ae2fd90dce7011f3f1c76eb4969577d5e
Author: maximilian.novikov@db.com <maximilian.novikov@db.com>
Date: Wed Jan 13 16:17:25 2021 +0100
Incremental Maven - Java 11 fix
commit b2f297566d5afcb0a285985cb5540685a28cafec
Author: maximilian.novikov@db.com <maximilian.novikov@db.com>
Date: Tue Jan 12 14:10:08 2021 +0100
Incremental Maven - initial commit
pzygielo
pushed a commit
to pzygielo/maven
that referenced
this pull request
Jan 4, 2023
Added the ability to configure how to handle "version" property.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use LoggerFactory to make sure we get the right instance to reset, as SimpleLoggerFactory.INSTANCE is not actually used by slf4j-simple's StaticLoggerBinder (instead it has its own SINGLETON field to hold the logger factory).
Can now remove temporary reflection workaround.