-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MNG-7862] The ModelLocator should always be used when locating pom.xml #1217
Conversation
d4c25f4
to
2da261f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this for v4 only? Some of the API changes look incompatible.
maven-model-builder/src/main/java/org/apache/maven/model/building/ModelSource3.java
Outdated
Show resolved
Hide resolved
maven-model-builder/src/main/java/org/apache/maven/model/building/ModelSource3.java
Outdated
Show resolved
Hide resolved
maven-model-builder/src/main/java/org/apache/maven/model/building/ModelSource3.java
Outdated
Show resolved
Hide resolved
Yes, I did not really envision to backport it. I think most of the changed methods are new in 4.0. The exceptions are the default value in the model and the new |
Probably unrelated but why in the CI output do I see :"Sending email to: rishi@ca.ibm.com"? |
Not sure, I've disabled the s390x pipeline as it does not take into account the fact that a given branch should be tested with the maven-integration-testing branch with the same name if it exists. |
OK, looks good overall. Is it possible to retrigger the full CI so we can see that S390 is no longer included? |
c009db4
to
4c40ad7
Compare
...c/test/java/org/apache/maven/internal/transformation/ConsumerPomArtifactTransformerTest.java
Outdated
Show resolved
Hide resolved
maven-model-builder/src/main/java/org/apache/maven/model/building/ModelSource3.java
Outdated
Show resolved
Hide resolved
maven-model-builder/src/main/java/org/apache/maven/model/building/ModelSource3.java
Outdated
Show resolved
Hide resolved
maven-model-builder/src/main/java/org/apache/maven/model/building/ModelSource3.java
Show resolved
Hide resolved
@elharo could you have another look ? |
JIRA issue: https://issues.apache.org/jira/browse/MNG-7862
IT PR: apache/maven-integration-testing#289
There are a few places where the
pom.xml
file name is hardcoded. There's a known interface to locate those, so those references should be cleaned.One IT has to be adjusted (see PR) because the default value in the model is changed from
../pom.xml
to..
for the parentrelativePath
default value.