Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MSHARED-1128] Introduce execute method and deprecate executeGoal(s) #43

Merged
merged 1 commit into from
Sep 12, 2022
Merged

[MSHARED-1128] Introduce execute method and deprecate executeGoal(s) #43

merged 1 commit into from
Sep 12, 2022

Conversation

slawekjaranowski
Copy link
Member

No description provided.

michael-o
michael-o reviewed Sep 11, 2022
View reviewed changes
Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments left. What I have noticed is that both system properties and env vars are read-write and can be retrieved. What is your opinion on this, should they be read-only or not getter at all?

src/main/java/org/apache/maven/shared/verifier/Verifier.java Show resolved Hide resolved
src/main/java/org/apache/maven/shared/verifier/Verifier.java Outdated Show resolved Hide resolved
@slawekjaranowski slawekjaranowski merged commit 6b9dbb5 into master Sep 12, 2022
@slawekjaranowski slawekjaranowski deleted the MSHARED-1128 branch September 12, 2022 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-o michael-o michael-o approved these changes

@gnodet gnodet Awaiting requested review from gnodet

Assignees
No one assigned
Labels
deprecated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slawekjaranowski @michael-o