-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MSHARED-1129] Prepare for replace CLI options with CLI args #42
Conversation
slawekjaranowski
commented
Sep 10, 2022
- add new methods
- deprecate old
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see a few inconsistency issues:
getCliArgs()
as read-only is missing- internal fields end with ...Arguments, but the methods with ...Args. Should be consistent. Either or.
2c6f6fe
to
0a3befc
Compare
There is no getCliArgs/getCliArguments methods - arguments are read only, there are only add methods
renamed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost perfect. A few open questions.
0a3befc
to
522a519
Compare
- add new methods - deprecate old
522a519
to
f25967c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now