Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MSHARED-1125] Require Maven args to be provided one by one #41

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

slawekjaranowski
Copy link
Member

No description provided.

Copy link
Contributor

@gnodet gnodet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Fwiw, I have found 32 references to such pattern in maven-integration-testing by looking for \.addCliOption\( "[\S]+ .*". A PR should be raised asap to align those, even before the switch to verifier 2.0.
Maybe we could add a helper method to add several arguments:

    public void addCliOptions( String... options )
    {
        ...
    }

@slawekjaranowski
Copy link
Member Author

I will look at integration tests.

@michael-o
Copy link
Member

What about invoker.properties?

@michael-o
Copy link
Member

Looks good to me. Fwiw, I have found 32 references to such pattern in maven-integration-testing by looking for \.addCliOption\( "[\S]+ .*". A PR should be raised asap to align those, even before the switch to verifier 2.0. Maybe we could add a helper method to add several arguments:

    public void addCliOptions( String... options )
    {
        ...
    }

This is a good idea with varargs...

@slawekjaranowski
Copy link
Member Author

What about invoker.properties?

it is not used here ... it is for maven-invoker-plugin - I think.

@michael-o
Copy link
Member

What about invoker.properties?

it is not used here ... it is for maven-invoker-plugin - I think.

Right, this is used by Invoker.

@michael-o
Copy link
Member

@slawekjaranowski FYI: https://issues.apache.org/jira/browse/MSHARED-1129

@slawekjaranowski slawekjaranowski merged commit f2ff914 into master Sep 7, 2022
@slawekjaranowski slawekjaranowski deleted the MSHARED-1125 branch September 7, 2022 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants