-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MSHARED-1125] Require Maven args to be provided one by one #41
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Fwiw, I have found 32 references to such pattern in maven-integration-testing
by looking for \.addCliOption\( "[\S]+ .*"
. A PR should be raised asap to align those, even before the switch to verifier 2.0.
Maybe we could add a helper method to add several arguments:
public void addCliOptions( String... options )
{
...
}
I will look at integration tests. |
src/test/java/org/apache/maven/shared/verifier/VerifierTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/apache/maven/shared/verifier/VerifierTest.java
Outdated
Show resolved
Hide resolved
What about |
This is a good idea with varargs... |
it is not used here ... it is for |
Right, this is used by Invoker. |
96c30e3
to
b7c9c43
Compare
b7c9c43
to
07c9ef5
Compare
No description provided.