Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Embedded3xLauncher with Maven Home #12

Merged
merged 1 commit into from
Mar 15, 2022
Merged

Test Embedded3xLauncher with Maven Home #12

merged 1 commit into from
Mar 15, 2022

Conversation

slawekjaranowski
Copy link
Member

No description provided.

@slawekjaranowski slawekjaranowski marked this pull request as draft March 14, 2022 22:26
@slawekjaranowski slawekjaranowski force-pushed the test-m-home branch 4 times, most recently from 96979dc to 7f12ea7 Compare March 14, 2022 22:52
@slawekjaranowski slawekjaranowski marked this pull request as ready for review March 14, 2022 22:56
@slawekjaranowski
Copy link
Member Author

@kwin - please review

kwin
kwin approved these changes Mar 15, 2022
View reviewed changes
Copy link
Member

@kwin kwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor nit

src/test/java/org/apache/maven/it/VerifierTest.java Outdated Show resolved Hide resolved
@slawekjaranowski slawekjaranowski merged commit 3ce0eee into master Mar 15, 2022
@slawekjaranowski slawekjaranowski deleted the test-m-home branch March 15, 2022 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwin kwin kwin approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slawekjaranowski @kwin