-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SUREFIRE-2051] Propagate exceptions while resolving artifacts in SurefireDependencyResolver
#504
Conversation
Right on the time! |
...refire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireDependencyResolver.java
Outdated
Show resolved
Hide resolved
@Tibor17 I propose postpone cosmetic changes, for next PR. |
@hisener thanks for contribution |
@slawekjaranowski which one? |
@slawekjaranowski |
@hisener |
Sorry, I am seeing this just now. I'll do that. |
…refireDependencyResolver`
@hisener |
Surefire doesn't propagate the exception during artifact resolution, and then later, it fails with a
NullPointerException
when it needs to access the artifact (inAbstractSurefireMojo.java#L4125
orSurefireDependencyResolver.java#L203
). This makes harder to understand the underlying issue. This change usesResolutionErrorHandler
to propagate the actual issue.Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles
,where you replace
SUREFIRE-XXX
with the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean install
to make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean install
).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.