Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SUREFIRE-1516] Poor performance in reuseForks=false #259

Closed
wants to merge 6 commits into from
Closed

Conversation

Tibor17
Copy link
Contributor

@Tibor17 Tibor17 commented Dec 27, 2019

Updated after PR #253 .

@olamy
Copy link
Member

olamy commented Dec 28, 2019

Are all package name changes related to the issue mentioned in the description?

@Tibor17
Copy link
Contributor Author

Tibor17 commented Dec 28, 2019

@olamy
No, of course not, but here I wanted to demonstrate whether commit from Jonathan would be stable after the latest chnages.
I think Jonathan's commit would be fine but it truly provocated the issue in SUREFIRE-1719 and therefore the issue SUREFIRE-1719 should be fixed before the PR #253 . At the Slack we talked about it so that the failed test ForkModeIT_testForkCountTwoNoReuse is related to the same symptoms with reuseForks=false and also we uncovered the root cause https://issues.apache.org/jira/browse/SUREFIRE-1719?focusedCommentId=16977946&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16977946

@Tibor17 Tibor17 closed this Dec 29, 2019
@Tibor17
Copy link
Contributor Author

Tibor17 commented Dec 29, 2019

I have cherrypicked the commits to master.

@asfgit asfgit deleted the cli branch April 19, 2020 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants