-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MNG-7559] Improve documentation of versions comparison #331
Conversation
d014203
to
06c0c64
Compare
b8c7c7a
to
bf0ef6d
Compare
34e13ad
to
1f8296b
Compare
code: documentation: |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be helpful to separate formatting and language changes from functionality changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is related to MNG-7559 but does not seem to fix it. It merely changes docs. That issue requests changes in behavior.
8422aa5
to
a7a43ed
Compare
reverted one comparison, and added another test case to prove website documentation right |
a7a43ed
to
040c1dd
Compare
i think i resolved everything, thank you for your feedback. waiting approval of last fixes. |
The test cases for MNG 7559 are here: maven-artifact/src/test/java/org/apache/maven/artifact/versioning/ComparableVersionTest.java
of all the error cases 2.3-pfd was the first declared on the issue and fixed. did i miss something ? |
040c1dd
to
fb4182c
Compare
fb4182c
to
d9f8b63
Compare
Fix versions comparison https://issues.apache.org/jira/browse/MNG-7559
intention is:
following semver rules should be encouraged, natural ordering is used without the need to hard code strings, except for hard coded qualifiers 'a', 'b', 'm', 'cr', 'snapshot', 'final', 'ga', 'release', '' and 'sp':
the documentation should discourage the usage of 'CR', 'final', 'ga', 'release' and 'SP' qualifiers.
Maven Central should begin to reject new artifact using CR and SP qualifiers.