Javadoc cleanup in preparation of release

[mthmulders]

No description provided.

[pzygielo]

Forgive me, but is there a chance you would consider removing one ; from

maven-shared-utils/src/test/java/org/apache/maven/shared/utils/xml/PrettyPrintXmlWriterTest.java

Line 37 in 4e93c56

private StringWriter w = new StringWriter();;

as well, please? It has no impact on javadoc, but I can't imagine better PR like this 😁

[mthmulders]

Forgive me, but is there a chance you would consider removing one ; from

maven-shared-utils/src/test/java/org/apache/maven/shared/utils/xml/PrettyPrintXmlWriterTest.java

Line 37 in 4e93c56

private StringWriter w = new StringWriter();;

as well, please? It has no impact on javadoc, but I can't imagine better PR like this 😁

Done.

[mthmulders]

Did you remove the default messages on these methods on purpose? If so, don't you think it adds value?

The remarks like "By default, bold cyan" refer to one particular implementation (the AnsiMessageBuilder) but they may not apply to other implementations (such as the PlainMessageBuilder). The interface should refrain from describing such implementation details, I would argue.

[MartinKanters]

Did you remove the default messages on these methods on purpose? If so, don't you think it adds value?

The remarks like "By default, bold cyan" refer to one particular implementation (the AnsiMessageBuilder) but they may not apply to other implementations (such as the PlainMessageBuilder). The interface should refrain from describing such implementation details, I would argue.

Right, makes sense to me!

[MartinKanters]

LGTM, feel free to squash and merge