Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MSHARED-860] deprecate PropertyUtils constructor and clean up docs #41

Merged
merged 5 commits into from
May 29, 2020
Merged

[MSHARED-860] deprecate PropertyUtils constructor and clean up docs #41

merged 5 commits into from
May 29, 2020

Conversation

elharo
Copy link
Contributor

@elharo elharo commented May 29, 2020

@elharo elharo requested a review from michael-o May 29, 2020 10:42
@elharo elharo merged commit a51b3eb into master May 29, 2020
@elharo elharo deleted the path branch May 29, 2020 14:43
jochenw
jochenw reviewed Jul 21, 2020
View reviewed changes
Copy link

@jochenw jochenw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Doesn't

try ( InputStream in = is )

end with closing the InputStream in (aka is)?

@roxspring
Copy link
Contributor

Question: Doesn't

try ( InputStream in = is )

end with closing the InputStream in (aka is)?

This has already been discussed here:
https://github.com/apache/maven-shared-utils/pull/41/files#r432415800

In short: Yes it closes the InputStream but the original code did too and changing the behaviour would be bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jochenw jochenw jochenw left review comments

@michael-o michael-o michael-o approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elharo @roxspring @michael-o @jochenw