[MSHARED-862] system independent file separator

[elharo]

@rfscholte see if we can make DirectoryScannerTest pass on Windows

[michael-o]

Let me run this too...

[elharo]

I'm a little confused why the jenkins build isn't firing on the latst commits:

https://builds.apache.org/job/maven-box/job/maven-shared-utils/

[michael-o]

Works for me on

Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T20:33:14+02:00)
Maven home: /usr/local/apache-maven-3.5.4
Java version: 1.8.0_242, vendor: Oracle Corporation, runtime: /usr/local/openjdk8/jre
Default locale: de_DE, platform encoding: UTF-8
OS name: "freebsd", version: "12.1-stable", arch: "amd64", family: "unix"

and

Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T20:33:14+02:00)
Maven home: C:\Entwicklung\Programme\apache-maven-3.5.4\bin\..
Java version: 1.8.0_242, vendor: Azul Systems, Inc., runtime: C:\Program Files\Zulu\zulu-8\jre
Default locale: de_DE, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

Suprisingly I see an unrelated failure:

[ERROR] Failures:
[ERROR]   MessageUtilsTest.testSystem:39
Expected: not sameInstance(<org.apache.maven.surefire.report.ConsoleOutputCapture$ForwardingPrintStream@2cfb4a64>)
     but: was <org.apache.maven.surefire.report.ConsoleOutputCapture$ForwardingPrintStream@2cfb4a64>

[elharo]

Interesting. I've never seen that one. Do you also see that one in master?

[michael-o]

Interesting. I've never seen that one. Do you also see that one in master?

Yes, same on master.

[elharo]

Build is blue (green) so I'm going to merge.

[michael-o]

Ouch, you just have provided 6 junk commits on master. Please avoid that by squashing first. No merge commit since they don't add any benefit for us.

[elharo]

Squash commits have a different negative side effect that Robert has asked me to avoid. You should probably bring this up on the dev mailing list, so the community can decide what they want. When a decision is made, the repos can be configured to make the preferred way the only way.

[michael-o]

Where did he request this?

[elharo]

Slack + email. I don't have a major preference here one way or the other, but I am getting contradictory requests about merging from different committers and PMC members, so let's figure out what everyone is most comfortable with, document that decision, and configure the repos to make it the default or only option.