Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MSHARED-1289] Deprecate library #165

Closed
wants to merge 1 commit into from
Closed

[MSHARED-1289] Deprecate library #165

wants to merge 1 commit into from

Conversation

kwin
Copy link
Member

@kwin kwin commented Jul 20, 2023

TODO:
Find replacements for

  1. org.apache.maven.shared.utils.cli.javatool and
  2. org.apache.maven.shared.utils.logging

Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more time: No. This is exactly wrong. We want to get rid of plexus, not use it more,.

@elharo elharo closed this Jul 20, 2023
@kwin
Copy link
Member Author

kwin commented Jul 20, 2023

Feel free to comment and decline but closing some other committers PR is a no go for me. Also you didn’t state no on the referenced mailing list thread. Reality is that plexus utils got more attention the last years and bugfixes were never backported to maven-shared-utils. We cannot afford maintaining both!

@kwin kwin reopened this Jul 20, 2023
@elharo
Copy link
Contributor

elharo commented Jul 20, 2023

We went through this a few weeks ago, This is not new.

I agree we can't maintain both. Plexus needs to go. That's been decided at least twice and we can't keep relitigating it.

@kwin
Copy link
Member Author

kwin commented Jul 20, 2023

Who decided and when? I know the original intent but that failed clearly. Also only 4 committers commented on the aforementioned thread. 3 in favor and you.

@elharo
Copy link
Contributor

elharo commented Jul 20, 2023

see #154 from less than a month ago.

@elharo
Copy link
Contributor

elharo commented Jul 20, 2023

Sorry, I was wrong. It was a month and three days ago; but I still don't want to have to close this same PR every month. Your time would be better spent replacing existing usages of plexus throughout maven or reviewing unreviewed PRs in this repo, among other things.

@elharo
Copy link
Contributor

elharo commented Aug 11, 2023

Still a hard no on this one. This needs to be dealt with one piece at a time, not as a single PR that deprecates things that are in use and that we don't have replacements for. Even more importantly, we need to eliminate plexus-utils, not reintroduce it. The foggy ownership and licensing story make it infeasible for Apache projects.

@michael-o michael-o removed their request for review August 11, 2023 19:39
Copy link
Member

@slawekjaranowski slawekjaranowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @elharo we should think rather about deprecate plexus-utils especially with licenses issues

So we should deprecate one by one feature which has replacement in JDK or other commons library.

@slachiewicz
Copy link
Member

Only packages listed by Konrad above must be kept in this lib, or we can find a replacement. All others are just duplicates.

@elharo elharo closed this Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants