Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MSHARED-1072] Poll data from input stream #140

Merged
merged 1 commit into from
May 8, 2023
Merged

Conversation

slawekjaranowski
Copy link
Member

Input stream can be a System.in - all read will be blocked
We need read data in no blocking mode

Input stream can be a System.in - all read will be blocked
We need read data in no blocking mode
@michael-o
Copy link
Member

Does this always apply? Are there cases were in the stream is not stdin?

@slawekjaranowski
Copy link
Member Author

Does this always apply? Are there cases were in the stream is not stdin?

It will be safer to use non blocking io in such case.
Even when stream will be not System.in it will work.

We also can not close provided stream because can be used for multiple executing of invoker.

@slawekjaranowski slawekjaranowski merged commit 1c264ba into master May 8, 2023
@slawekjaranowski slawekjaranowski deleted the MSHARED-1072 branch May 8, 2023 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants