Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MSHARED-1122] FileUtils: avoid getCanonicalPath() #114

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

jukzi
Copy link

@jukzi jukzi commented Aug 22, 2022

Use java.nio.Files.isSameFile() to compare path. Since JDK 12
getCanonicalPath() is not cached anymore and very slow on windows.

Use java.nio.Files.isSameFile() to compare path. Since JDK 12
getCanonicalPath() is not cached anymore and very slow on windows.
@jukzi
Copy link
Author

jukzi commented Aug 22, 2022

@jukzi
Copy link
Author

jukzi commented Sep 5, 2022

@slawekjaranowski mind to review?

@slawekjaranowski slawekjaranowski merged commit 40af112 into apache:master Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants