-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MSHADE-306] log all duplicates to not silently swallow a duplicate and an implicit selection #10
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
I will push to repo so that CI will test it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI fails. See the logs with the given link above
seems i cant run the CI job but I hope my fixes solved the issue |
@rmannibucau I will push the branch to master ASF repository so that CI will kick in. I hope we will be able to let CI start automatically upon pull requests changes, but currently I think it is not possible because Maven CI is really complex and it is very tied to ASF repo. as you know all Apache repos will be migrated to github and I hope it will be easier to change CI bindings. |
Unfortunately there are Test failures: https://builds.apache.org/job/maven-box/job/maven-shade-plugin/job/MSHADE-306/ |
…nd an implicit selection Closes #10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Rebased cccc31d and now CI is green also.
https://builds.apache.org/job/maven-box/job/maven-shade-plugin/job/MSHADE-306/
… and an implicit selection
beb45f7
to
2682f6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MSHADE-XXX] - Fixes bug in ApproximateQuantiles
,where you replace
MSHADE-XXX
with the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verify
to make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean verify
).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.
already an ASF committer