Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRELEASE-1145] Upgrade to Maven 3.6.3 #217

Merged
merged 1 commit into from
Jun 13, 2024
Merged

[MRELEASE-1145] Upgrade to Maven 3.6.3 #217

merged 1 commit into from
Jun 13, 2024

Conversation

michael-o
Copy link
Member

@cstamas Please have a sharp look before I continue upgrading. I am not 100% certain that my fix is correct.

@michael-o
Copy link
Member Author

Amy opinion on the modified code? Otherwise I will update piece by piece and merge next couple of days.

Copy link
Member

@cstamas cstamas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, go ahead

@michael-o
Copy link
Member Author

LGTM, go ahead

Does the getter change makes sense?

@cstamas
Copy link
Member

cstamas commented Jun 13, 2024

For me does, as I explained you when showed the gist: https://gist.github.com/cstamas/b847b879a0ca072c8cdc2aac4f2ce797

You are not interested in full transitive hull, you release this current project (but you need to get resolved versions if ranges are used).

@michael-o michael-o marked this pull request as ready for review June 13, 2024 19:31
@michael-o michael-o changed the title Mrelease 1145 [MRELEASE-1145] Upgrade to Maven 3.6.3 Jun 13, 2024
@asfgit asfgit merged commit fa6c3db into master Jun 13, 2024
47 of 51 checks passed
@michael-o michael-o deleted the MRELEASE-1145 branch June 13, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants