-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRELEASE-1123] Fix for Maven 4 compatibility #186
Conversation
e9c80be
to
ca5b587
Compare
...se-manager/src/main/java/org/apache/maven/shared/release/phase/GenerateReleasePomsPhase.java
Show resolved
Hide resolved
...se-manager/src/main/java/org/apache/maven/shared/release/phase/GenerateReleasePomsPhase.java
Show resolved
Hide resolved
@nielsbasjes, can you verify this on your end as well? |
I installed Apache Maven 4.0.0-alpha-5. All of this worked fine for me (except for my project having a few minor things that are not maven 4 compatible). So from my end this all looks good. |
Thanks, this is good news! |
@nielsbasjes thanks for testing. I will remove a build by Maven 4.x - and prepare for merge. |
maven-release-plugin/src/it/projects/perform/MRELEASE-592/pom.xml
Outdated
Show resolved
Hide resolved
maven-release-plugin/src/it/projects/prepare/MRELEASE-571_M3/module1/pom.xml
Outdated
Show resolved
Hide resolved
ca5b587
to
cd2fd7e
Compare
cd2fd7e
to
b9356bd
Compare
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MRELEASE-XXX] - Fixes bug in ApproximateQuantiles
,where you replace
MRELEASE-XXX
with the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verify -Prun-its
to make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.