Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRELEASE-1104] fix stage goal when having both arguments and stagingRepository #151

Merged
merged 1 commit into from
Oct 1, 2022

Conversation

olamy
Copy link
Member

@olamy olamy commented Sep 23, 2022

Signed-off-by: Olivier Lamy olamy@apache.org

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MJAVADOC-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MJAVADOC-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify -Prun-its to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@olamy olamy added the bug label Sep 23, 2022
@olamy olamy marked this pull request as draft September 23, 2022 07:39
@olamy olamy marked this pull request as ready for review September 23, 2022 07:50
@olamy olamy force-pushed the MRELEASE-1104-stagingRepository-ignored branch 2 times, most recently from b15ff9f to f3166d2 Compare September 23, 2022 11:09
@olamy olamy requested review from michael-o and slawekjaranowski and removed request for michael-o September 23, 2022 11:17
@michael-o
Copy link
Member

Let me try to run ITs here...

Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…Repository

Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy olamy force-pushed the MRELEASE-1104-stagingRepository-ignored branch from f7d5937 to 30d3ef1 Compare October 1, 2022 04:41
@olamy olamy merged commit 83deb62 into master Oct 1, 2022
@olamy olamy deleted the MRELEASE-1104-stagingRepository-ignored branch October 1, 2022 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants