-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MNG-6825] Replace StringUtils with Commons Lang3 #120
[MNG-6825] Replace StringUtils with Commons Lang3 #120
Conversation
Co-authored-by: Moderne <team@moderne.io>
The failing build is likely broken already. I'm looking into it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase. The failing CI should now pass, and then we'll be good to go.
Resolved the conflicts, but I assume we'll want to first remove the |
I don't think we have to remove StringUtils.is(Not)Empty/Blank first, though it's fine if someone wants to do that. |
Looks like we'll move away from commons-lang3 instead; https://issues.apache.org/jira/browse/MNG-6829 |
JDK > commons-lang3 > maven-shared-utils > plexus-utils If we can go straight to JDK only, wonderful, but I'd still approve a PR that replaces plexus with commons lang. |
sure, if this is still relevant, do it |
No description provided.